Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rules to those agreed upon in prior staff meeting. #491

Merged
merged 3 commits into from
May 15, 2021
Merged

Change rules to those agreed upon in prior staff meeting. #491

merged 3 commits into from
May 15, 2021

Conversation

swfarnsworth
Copy link
Member

This PR changes the rules page to match the rewrite we discussed internally. This PR should only be merged when an admin is available to update the rules displayed in the client.

@swfarnsworth swfarnsworth added the area: admin Related to the admin interface label May 14, 2021
Akarys42
Akarys42 approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@Akarys42 Akarys42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! You have a failed lint due to whitespace, you can fix it using:

pipenv run lint
git commit --amend --no-edit

Don't forget to setup pre-commit!

HassanAbouelela
HassanAbouelela approved these changes May 15, 2021
View reviewed changes
Copy link
Member

@HassanAbouelela HassanAbouelela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but like @Akarys42 said, let's fix linting.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c7c3541 on swfarnsworth/rules_update into 8641344 on main.

@ChrisLovering ChrisLovering merged commit 20aa50e into main May 15, 2021
@ChrisLovering ChrisLovering deleted the swfarnsworth/rules_update branch May 15, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akarys42 Akarys42 Akarys42 approved these changes

@HassanAbouelela HassanAbouelela HassanAbouelela approved these changes

Assignees
No one assigned
Labels
area: admin Related to the admin interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@swfarnsworth @coveralls @Akarys42 @HassanAbouelela @ChrisLovering