Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Jam 8 - Initial PR for Announcement #528

Merged
merged 12 commits into from
Jun 15, 2021
Merged

Code Jam 8 - Initial PR for Announcement #528

merged 12 commits into from
Jun 15, 2021

Conversation

janine9vn
Copy link
Contributor

This Pull Request is just the basics required for the Code Jam announcement. It does the following things:

  1. Add in basic assets for the event
  2. Create the CJ8 pages
  3. Update the main events page and the main code jam page

There will be a second PR made this Sunday that will have more of the details and include the Qualifier release.

Added images for the event, including the website banner
and images for the different approved frameworks.
Updating the list for upcoming and previous code jams.
This includes the overall "Upcoming Events" on the main events page.

I will do better in the future to update this as we have upcoming events
Making it more obvious that we have an ongoing code jam
that is available to join soon.
Created the main code jam event page.
It has barebones information with another more substantial
update to be PRed this upcoming Sunday.
Created a page listing the approved frameworks for CJ8.
This changes the look of the sidebar.
I've decided to put the Important Links in a panel item.
This makes it more obvious and draws more attention to it.

Additionally, I've put it above the sponsors for the above reasons.
@janine9vn janine9vn added area: frontend Related to site content and user interaction priority: 1 - high High Priority labels Jun 15, 2021
Co-authored-by: Joe Banks <joseph@josephbanks.me>
@jb3 jb3 enabled auto-merge June 15, 2021 02:17
Copy link
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than linting failure, all looks good, approving.

Copy link

@jacobmonck jacobmonck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jb3 jb3 disabled auto-merge June 15, 2021 02:24
Copy link

@Shivansh-007 Shivansh-007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait

pydis_site/templates/events/pages/code-jams/8/_index.html Outdated Show resolved Hide resolved
<li>
<p>
Your team, once the coding portion of the code jam is complete, must create a video presentation that showcases and explains your final product.
This must be in a video format and must be uploaded somewhere for the judges to view (i.e. unlisted youtube video, vimeo, etc.)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This must be in a video format and must be uploaded somewhere for the judges to view (i.e. unlisted youtube video, vimeo, etc.)
This must be in a video format and must be uploaded somewhere for the judges to view (i.e. unlisted YouTube video, Vimeo, etc.)

Copy link
Contributor

@dawnofmidnight dawnofmidnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trailing whitespace got merged with a commit made through
the Github UI editor. Never again shall I trust it!

Also capitalized Vimeo and Youtube.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 23a3f67 on cj8_announcement into 1fd6c9b on main.

@jb3 jb3 merged commit b8132bd into main Jun 15, 2021
@jb3 jb3 deleted the cj8_announcement branch June 15, 2021 02:36
jb3 added a commit that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to site content and user interaction priority: 1 - high High Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants