Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Jam 8 Site Updates - v2 #530

Merged
merged 10 commits into from
Jun 15, 2021
Merged

Code Jam 8 Site Updates - v2 #530

merged 10 commits into from
Jun 15, 2021

Conversation

janine9vn
Copy link
Contributor

This PR adds some additional changes required before we can make the code jam 8 announcement.
Summary of changes:

  • Updated Import Dates to reflect that the announcement is going out today
  • Changed main NavBar to have one Events tab that should bring you to the main event page
  • Updated wording about joining the Discord server
  • Correctly spelled GitHub, YouTube
  • Added in DigitalOcean as a Sponsor
  • Clarified and updated the rules
  • Ensured consistency for "Approved Frameworks"
  • Added documentation links for the approved frameworks

janine9vn and others added 7 commits June 14, 2021 23:19
Correct, clarify, and simply the rules for this code jam.
The changes include minor corrections and details for clarity.
Additionally, the technology was described in greater detail.
Added in documentation links for each of the frameworks.
Added in DigitalOcean as one of the sponsors for this codejam.
I'm making what might be considered a radical change to the navbar.
I'm no longer splitting out events as its own category at the bottom.
Instead I'm putting it higher above between Tools and Contributing.
I don't think events being separate at the bottom makes much sense
and I think it actively hurts discoverability of it. Ideally I'd like to
link to just the main events page and that's the hub for it all.
I don't want to have to continually change the navbar twice a year for a
codejam.
@janine9vn janine9vn added area: frontend Related to site content and user interaction priority: 1 - high High Priority labels Jun 15, 2021
@coveralls
Copy link

coveralls commented Jun 15, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling f1996ac on cj8-updates into b8132bd on main.

@jb3 jb3 enabled auto-merge (squash) June 15, 2021 15:02
Copy link
Contributor

@ToxicKidz ToxicKidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change

pydis_site/templates/events/sidebar/code-jams/8.html Outdated Show resolved Hide resolved
Co-authored-by: ToxicKidz <78174417+ToxicKidz@users.noreply.github.com>
@janine9vn janine9vn requested a review from ToxicKidz June 15, 2021 15:19
Copy link
Contributor

@ToxicKidz ToxicKidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jb3 jb3 merged commit 522f14a into main Jun 15, 2021
@jb3 jb3 deleted the cj8-updates branch June 15, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to site content and user interaction priority: 1 - high High Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants