Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approve more frameworks for CJ8 #532

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Approve more frameworks for CJ8 #532

merged 1 commit into from
Jun 15, 2021

Conversation

janine9vn
Copy link
Contributor

  • Python Prompt Toolkit is added as an approved framework.
  • Unicurses and nurses are added as additional frameworks you can use with curses, although it's a use at your own risk and no promises are made for functionality or stability.

@janine9vn
Approve more frameworks
cd53fc5 
Python Prompt Toolkit is added as an approved framework.
Unicurses and nurses are added as additional frameworks you can use with
curses, although it's a use at your own risk and no promises are made
for functionality or stability.
@janine9vn janine9vn added area: frontend Related to site content and user interaction priority: 1 - high High Priority labels Jun 15, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cd53fc5 on cj8-frameworks-update into 35dc1c4 on main.

jacobmonck
jacobmonck approved these changes Jun 15, 2021
View reviewed changes
Copy link

@jacobmonck jacobmonck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, looks good to me.

@jb3 jb3 merged commit 865c2ed into main Jun 15, 2021
@jb3 jb3 deleted the cj8-frameworks-update branch June 15, 2021 23:39
fisher60
fisher60 approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@fisher60 fisher60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, maybe consider changing Unicurses to UniCurses to match the pypi project, but this is such a tiny detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb3 jb3 jb3 approved these changes

@fisher60 fisher60 fisher60 approved these changes

@jacobmonck jacobmonck jacobmonck approved these changes

Assignees
No one assigned
Labels
area: frontend Related to site content and user interaction priority: 1 - high High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@janine9vn @coveralls @jb3 @fisher60 @jacobmonck