Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update navbar hamburger/dropdown anchors to spans #538

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Update navbar hamburger/dropdown anchors to spans #538

merged 2 commits into from
Jun 24, 2021

Conversation

jb3
Copy link
Member

@jb3 jb3 commented Jun 20, 2021

There is no href on these items, so they should not be anchors.

@jb3
Update navbar hamburger/dropdown anchors to spans
d2112a8 
There is no href on these items, so they should not be anchors.
@coveralls
Copy link

coveralls commented Jun 20, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 7e8d29c on jb3/navbar-spans into b74f8c7 on main.

doublevcodes
doublevcodes approved these changes Jun 20, 2021
View reviewed changes
Copy link
Contributor

@doublevcodes doublevcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

janine9vn
janine9vn approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@janine9vn janine9vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change, lgtm.

ToxicKidz
ToxicKidz approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@ToxicKidz ToxicKidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@janine9vn janine9vn merged commit 5f1ab78 into main Jun 24, 2021
@janine9vn janine9vn deleted the jb3/navbar-spans branch June 24, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janine9vn janine9vn janine9vn approved these changes

@doublevcodes doublevcodes doublevcodes approved these changes

@ToxicKidz ToxicKidz ToxicKidz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jb3 @coveralls @janine9vn @doublevcodes @ToxicKidz