Supports debian_version file content for version(best=True) calls
#333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From ansible/ansible#77928 and #332, it appeared that Debian >= 9 do not ship anymore the `MINOR` SemVer segment in `lsb_release` "distribution release" output. This means that setting `best=True` cannot be used to retrieve it, and thus behaves differently across Debian < 10 and Debian >= 10. This patch implements `/etc/debian_version` file parsing to workaround this issue, on "Debian-like" distributions.
hartwork
reviewed
Jun 5, 2022
There was a problem hiding this comment.
Hi @HorlogeSkynet I like the general direction 👍, please see two comments on details below:
Hey @hartwork ! Thanks for your quick feedback, see my replies to your comments 😉 |
hartwork
approved these changes
Jun 5, 2022
HorlogeSkynet
added a commit
that referenced
this pull request
Jun 7, 2022
HorlogeSkynet
added a commit
that referenced
this pull request
Jun 7, 2022
HorlogeSkynet
added a commit
that referenced
this pull request
Jun 7, 2022
HorlogeSkynet
added a commit
that referenced
this pull request
Jun 21, 2022
HorlogeSkynet
added a commit
that referenced
this pull request
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @python-distro/maintainers,
From ansible/ansible#77928 and #332, it appeared that Debian >= 9 do not ship anymore the
MINORSemVer segment inlsb_release"distribution release" output.This means that setting
best=Truecannot be used to retrieve it, and thusversion(best=True)behaves differently across Debian < 10 and Debian >= 10.This patch implements
/etc/debian_versionfile parsing to workaround this issue, on "Debian-like" distributions.Many thanks, bye 👋