New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autocompletion support #941
feat: add autocompletion support #941
Conversation
Thanks for this feature. Doesn't work for me with the provided instructions and zsh. |
Hi! Indeed it doesn't work. I thought it was just my setup that didn't work. I don't really use zsh so my testing of it was light. The other shells do work though. I use this patch in bash all the time with no problems at all. Argcomplete sounded like a quick win. It's used by pipx 1 and others. Should I remove any mention of zsh from the docs? Or should we mention zsh support as experiemental/broken with a reference to the issue 2? |
@mchlumsky I guess we should add a notice that it doesn't work with zsh. Can we make |
I kept the commits separate for clarity but I can squash them into one once they pass peer-review. |
@mchlumsky Looks good to me now! Could you just squash those commits and then we can merge it 😃 |
Commits squashed! However travis-ci testing is failing during some rate-limit testing in py_func_v4. |
@mchlumsky Sadly the build pipeline is not as stable as I want it to be. But I can't figure out why as everything works fine locally, everytime. |
@max-wittig The test that failed in my run was this one. It's a rate limit test, which can be almost described as a performance test. The test fails because it can't trigger the rate limiting feature of gitlab. This kind of test is hard to achieve on a public shared service like travis-ci where the VMs running your tests can have very different sizes and/or workloads. |
@mchlumsky Thank you, but credit goes to the original creator of this lib, not to me. @gpocentek |
But I guess we should remove this test. |
Fixes #637