Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to the src/ layout #184

Closed
jamadden opened this issue Sep 30, 2020 · 1 comment · Fixed by #208
Closed

Move to the src/ layout #184

jamadden opened this issue Sep 30, 2020 · 1 comment · Fixed by #208
Labels
Internal Discussions on processes, etc, that don't directly face end users
Milestone
1.0

Comments

@jamadden
Copy link
Contributor

jamadden commented Sep 30, 2020 •
edited

This has some advantages. One that I've come to very much appreciate is separating out the build-in-place directories from the (usual) working directory. This should obviate some of the need for workarounds like

greenlet/run-tests.py

Lines 44 to 47 in 71ecaa8

# -- find greenlet but skip the one in "."
if not build:
oldpath = sys.path[:]
sys.path.remove(here)

I also intend to distribute (and install) the source and tests in the binary distributions; they are small, but provide benefit for end users trying to debug issues, or just understand how greenlet works without having to go to github. I don't see any penalties for that besides a negligible size increase.
@jamadden jamadden added the Internal Discussions on processes, etc, that don't directly face end users label Sep 30, 2020
@jamadden jamadden added this to the 1.0 milestone Sep 30, 2020
@snaury
Copy link
Contributor

snaury commented Oct 1, 2020

Just in case, make sure you update paths in the LICENSE file, so files that are under PSF license (most of greenlet is MIT, but files that came from stackless are PSF) are correctly marked.

jamadden added a commit that referenced this issue Nov 11, 2020
@jamadden
Remove custom my_build_ext and stop trying to build extensions at tes…
fbcc055 
…t time.

Building the extensions and getting them in the right place is the job of tox.

This includes a temporary minor regression in that the test extensions are now also packaged in the binary distributions. This will be resolved with #189 and #184.

Removes some (maybe all, didnt check yet) uses of distutils so partly addresses #185.

Fixes #187
jamadden added a commit that referenced this issue Nov 11, 2020
@jamadden
Remove custom my_build_ext and stop trying to build extensions at tes…
c80fab9 
…t time.

Building the extensions and getting them in the right place is the job of tox.

This includes a temporary minor regression in that the test extensions are now also packaged in the binary distributions. This will be resolved with #189 and #184.

Removes some (maybe all, didnt check yet) uses of distutils so partly addresses #185.

Fixes #187

Specify an image for appveyor that works for Python 2.7 (the right
visual studio is missing on other images)

Add installation of missing python versions.

Use PYTHON, not PYTHON_ROOT on appveyor. The former is more common in my experience.

Use a newer image for 3.9 on appveyor
jamadden added a commit that referenced this issue Nov 12, 2020
@jamadden
Move to the src/ layout, and make greenlet a package.
8448b09 
Make 'tests' become 'greenlet.tests', and be compatible with 'python -m unittest discover'.

Fixes #184. Fixes #184. Fixes #189.
@jamadden jamadden mentioned this issue Nov 12, 2020
Merged
@jamadden jamadden mentioned this issue Mar 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internal Discussions on processes, etc, that don't directly face end users
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Move to the src/ layout, and make greenlet a package. python-greenlet/greenlet
2 participants
@snaury @jamadden