Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the custom my_build_ext #187

Closed
jamadden opened this issue Sep 30, 2020 · 0 comments
Closed

Drop the custom my_build_ext #187

jamadden opened this issue Sep 30, 2020 · 0 comments
Labels
Internal Discussions on processes, etc, that don't directly face end users
Milestone
1.0

Comments

@jamadden
Copy link
Contributor

It says it was taken from gevent, but gevent doesn't use that code anymore.

It also directly imports distutils, which is deprecated. It probably exists specifically for distutils support.
@jamadden jamadden added the Internal Discussions on processes, etc, that don't directly face end users label Sep 30, 2020
@jamadden jamadden added this to the 1.0 milestone Sep 30, 2020
jamadden added a commit that referenced this issue Nov 11, 2020
@jamadden
Remove custom my_build_ext and stop trying to build extensions at tes…
c80fab9 
…t time.

Building the extensions and getting them in the right place is the job of tox.

This includes a temporary minor regression in that the test extensions are now also packaged in the binary distributions. This will be resolved with #189 and #184.

Removes some (maybe all, didnt check yet) uses of distutils so partly addresses #185.

Fixes #187

Specify an image for appveyor that works for Python 2.7 (the right
visual studio is missing on other images)

Add installation of missing python versions.

Use PYTHON, not PYTHON_ROOT on appveyor. The former is more common in my experience.

Use a newer image for 3.9 on appveyor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internal Discussions on processes, etc, that don't directly face end users
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@jamadden