-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use %d
for year translations, convert to string for intcomma
after
#23
Conversation
This patch fixes a bug introduced in 3.14.0, where the format string was changed from %d to %s to add separators to the year. However, this needs to happen after translation because the translator uses the format strings as part of the translation. Closes python-humanize#21
Thanks for the fix! Please could you also add a test to |
Could you please assign me so I don't forget! Thanks! |
Done! Will set to draft as well. |
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 99.09% 99.11% +0.01%
==========================================
Files 9 9
Lines 666 678 +12
==========================================
+ Hits 660 672 +12
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thank you! |
%d
for year translations, convert to string for intcomma
after
%d
for year translations, convert to string for intcomma
after%d
for year translations, convert to string for intcomma
after
This patch fixes a bug introduced in 3.14.0, where the format
string was changed from %d to %s to add separators to the year.
However, this needs to happen after translation because the
translator uses the format strings as part of the translation.
Closes #21