Switch event classes to dataclasses #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _EventBundle used previously dynamically creates the Event
classes, which makes typing hard. As the Event classes are now stable
the dynamic creation isn't required, and as h11 supports Python3.6+
dataclasses can be used instead.
This now makes the Events frozen (and almost imutable) which better
matches the intended API. In turn it requires the
object.__setattr__
usage and the alteration to the
_clean_up_response_headers_for_sending
method.This change also improves the performance a little, using the
benchmark,
Before: 6.7k requests/sec
After: 6.9k requests/sec
Notes:
The test response-header changes are required as the previous version
would mutate the response object.
The init for the Data event is required as slots and defaults aren't
possible with dataclasses.