Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the test to fail even if coverage is good #60

Merged
merged 8 commits into from
Sep 26, 2016
Merged

Conversation

Lukasa
Copy link
Member

@Lukasa Lukasa commented Aug 15, 2016

Currently it seems that the CI tests pass even if tests fail, so long as coverage is met. That's dumb.

@Lukasa
Copy link
Member Author

Lukasa commented Aug 15, 2016

Hrm, I'm not sure I want to do this. @tatsuhiro-t, do you have any good insight into why nghttp2 isn't installing properly anymore? It used to work, and then I discovered it stopped working a while ago. See, for example, this test.

If none of @python-hyper/contributors or @tatsuhiro-t have time to work this out, I'll go ahead and merge this PR, which basically just removes nghttp2 support. I certainly don't have the time to dive into this at this time, and I'd rather get everything cleaned up than wait forever for someone to fix this up, but I'm prepared to wait a few days to give people time. It'd be nice to keep (and indeed improve!) the nghttp2 integration.

@tatsuhiro-t
Copy link
Contributor

Do you make sure that shared library of nghttp2 python library is installed somewhere you expected?

@Lukasa
Copy link
Member Author

Lukasa commented Aug 15, 2016

@tatsuhiro-t I believe I do, but it's possible that that's not been done correctly now that I think about it. Let me investigate a bit.

@tatsuhiro-t
Copy link
Contributor

I setup docker, and boot up ubuntu 16.04, installed required packages (cython from official ubuntu package), and run make install nghttp2 to default location (/usr/local/).
After ldconfig, I can import nghttp2 from python interactive terminal.

@Lukasa
Copy link
Member Author

Lukasa commented Aug 15, 2016

Yeah, so the issue with that on Travis is that we end up using a Python virtual environment, so we need to be careful with how the install runs.

@Lukasa
Copy link
Member Author

Lukasa commented Sep 26, 2016

I think at this point it's not really practicable to keep this patch out of tree. We'll need to add a task item to re-add nghttp2 support.

@Lukasa Lukasa merged commit 85f3952 into master Sep 26, 2016
@Lukasa Lukasa deleted the test-not-failing branch September 26, 2016 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants