Added Huffman decoder and tests #5
Conversation
| from hyper.http20.huffman_constants import REQUEST_CODES,REQUEST_CODES_LENGTH,RESPONSE_CODES,RESPONSE_CODES_LENGTHS | ||
|
|
||
| def _pad_binary(bin_str,req_len = 8): | ||
| return max(0,(req_len) - len(bin_str)) * '0' + bin_str |
There was a problem hiding this comment.
Can you leave a space after the comma between method arguments? E.g max(a, b).
There was a problem hiding this comment.
This applies to function definitions, e.g. def _pad_binary(bin_str, req_len=8). Also, in function definitions where some keywords have default values, don't put a space around the = sign. Do it like I just did in the example.
|
This looks really excellent, thankyou! I've left some comments inline, but they're all stylistic. Let me know when you're done and I'll swing through it again. =) |
| 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, | ||
| 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, | ||
| 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, | ||
| 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26, 26] |
There was a problem hiding this comment.
Can we move this closing square bracket down to the next line?
|
Ok, two small further markups, pretty trivial. =) |
|
Thanks so much! I've merged it manually, since there were a few small changes I wanted to make. I've added you to the Contributors list. Again, thankyou, this is work I desperately needed done and couldn't find the time to do! 🍰 🍪 ⭐ 🌟 |
Kinda new to python. Could you review it, so I can fix any code quality issues which might be present.