Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only do branch builds on master. #15

Merged
merged 1 commit into from
May 4, 2017
Merged

Only do branch builds on master. #15

merged 1 commit into from
May 4, 2017

Conversation

Lukasa
Copy link
Member

@Lukasa Lukasa commented May 4, 2017

Because the Travis build time is quite long, it'd be much better to reduce the number of builds we have to do. Normally, from branches within the repo, Travis will build them twice: once for the branch, once for the PR. We shouldn't do that: one build is plenty.

@codecov-io
Copy link

codecov-io commented May 4, 2017

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   81.96%   81.96%           
=======================================
  Files           5        5           
  Lines         693      693           
  Branches      163      163           
=======================================
  Hits          568      568           
  Misses         76       76           
  Partials       49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856c74b...71c7dcd. Read the comment docs.

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lukasa Lukasa merged commit 0872c53 into master May 4, 2017
@Lukasa Lukasa deleted the reduce-travis-builds branch May 4, 2017 14:18
@njsmith
Copy link
Member

njsmith commented May 6, 2017

If this becomes a problem due to like, blocking Travis builds on other projects in the organization (that's a thing, right?), then it can almost certainly be trimmed further without too much pain. Like we could probably drop 3.4 without anyone noticing, and that's 1/3 of the builds right there. And we probably don't need to re-run the whole test suite twice with and without wsaccel on every platform.

@Lukasa
Copy link
Member Author

Lukasa commented May 6, 2017

Indeed. Right now this was just a trivial win of removing duplicate testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants