Fix running tests with jpeg, tiff and zlib support being unavailable #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .tar test requires both jpeg & zlib support. If one of the two is unavailable, run the test for the second one. If both are unavailable, skip the test.
If PNG (zlib) support is disabled, use .pcx for test_image_split which is unconditional. Since it does not support RGBA, skip the RGBA test. Otherwise, just use PNG and do the full test.
|
As a side note, this only fixes the |
|
Would you be able to pick the correct commits from this PR and merge them so I could rebase my work on top of it? I find Mercurial very hard to use compared to git, so I would prefer avoiding trying to do something like this myself :). |
|
yeah, I'll split those out. |
wiredfool
added a commit
that referenced
this pull request
Apr 21, 2013
Skip tests for features that aren't compiled in, includes #199
|
Wait, why did I think Mercurial's involved? :D I guess I've mistaken this with the other PR I sent today. I'll try to take a second look at the tests tomorrow. |
|
I added the libtiff test changes in #201, so I think we're set there. |
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Sep 24, 2023
Fix expected features list on Travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the current tests are skipped properly when relevant features are not available. This patch adds similar measures to all the remaining tests, so that the test suite succeeds even with all features being disabled.
In most cases, this was done through conditional test skipping.
test_imagefileis done only on the formats that are enabled.test_image_draftgets a fallback to a PCX file (and no RGBA) if PNG is not available.