Allowing to pass font as file-like objects

[Mibou]

This is the update to allow to pass fonts as file-like objects. Thank you wiredfool and aclark4life.

[wiredfool]

A couple things I want to check:

• The buf object has to be read only while the font is using it.
• We're going to need tests on this one.
• I'm not 100% sure on the interface changes. When we're reading images, the filename/file like object is passed in as the same parameter. I don't generally like variable type parameters, but it's consistent with the rest of the interface.

[Mibou]

Ok. I will do the modifications and pull them back to you. The reason I kept filename variable was not to break retrocompatibility and I didn't want to pass my file like object through the filename variable.

Do you think it's ok if I change the filename variable to a font variable ?

[wiredfool]

Looking at this a bit more, I'm not sure that file_like.buf is generally valid. It's certainly not in the declared interface for StringIO or file, where one can rely on read/write/close, and getvalue for stringio.

I think it's probably safe to rename that parameter, it might be safer to do something like:

 def __init__(self, font=None, size=10, index=0, encoding="", file=None):
       if file:
             # try raising a deprecation warning here, 
             font = file

       if isStringType(font):
             self.font = core.getfont(...)
       else: # file_like
             self.bytes = font.read()
             self.font = core.getfont( with bytes and length...)

Keeping the bytes as an instance variable should satisfy the read only buffer that's required as long as the font's in use.

At some point, I intend to grab as many packages as I can from debian and wherever else so that I can grep through them to see how PIL is being used to check compatibility. This would be something I'd like to test, greping for FreeTypeFont | grep file

[Mibou]

Ok thank you. I did the changes and added the unitests. So I think it should be ok now !
Thank you for your feedback.

[wiredfool]

Thanks for the update. I'll review this soon. I want to look closely and carefully.

[wiredfool]

I've added a few changes in #209.

• I've made the read buffer an instance variable for FreetypeFont, so that it has the same lifetime as the font object
• I've renamed file_like to font_bytes in the c code, so that it sounds more like a buffer (it's just bytes at that point)
• I've added tests.

Thanks for your contribution.