-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace $ref
& $dynamicRef
support / RefResolver
with the new referencing library
#1049
Commits on Feb 21, 2023
-
Referencing happens to not support it at the minute. It's close to EOL, so rather than adding it, I suspect it's droppable.
Configuration menu - View commit details
-
Copy full SHA for 0ce3cef - Browse repository at this point
Copy the full SHA 0ce3cefView commit details -
Move to retrieving schemas from the jsonschema-specifications registry.
Still will be tweaked as the referencing library's public API changes.
Configuration menu - View commit details
-
Copy full SHA for bf94d57 - Browse repository at this point
Copy the full SHA bf94d57View commit details -
Deprecate jsonschema.RefResolver from both places it is importable.
Internal uses of it will be removed, replaced with referencing's resolution APIs, though RefResolver will continue to function during its deprecation period.
Configuration menu - View commit details
-
Copy full SHA for 238e711 - Browse repository at this point
Copy the full SHA 238e711View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6aa053 - Browse repository at this point
Copy the full SHA f6aa053View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c8f643 - Browse repository at this point
Copy the full SHA 2c8f643View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52340d7 - Browse repository at this point
Copy the full SHA 52340d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ec24ab - Browse repository at this point
Copy the full SHA 4ec24abView commit details -
Move reference resolution to a (private) Validator method.
This will make it easier to swap over to referencing's Resolver (while preserving backwards compat for anyone who passes a RefResolver to a Validator). At some point in the future this method may become public (which will make it easier for external dialects to resolve references) but let's keep it private for a bit until it's clear that the interface is stable -- a future draft might do crazy things like have adjacent properties to $ref affect the resolution behavior, which would make this method need to take more than just the $ref value.
Configuration menu - View commit details
-
Copy full SHA for 9da55df - Browse repository at this point
Copy the full SHA 9da55dfView commit details -
It will imminently be replaced by referencing.Registry-based resolution.
Configuration menu - View commit details
-
Copy full SHA for 635dc13 - Browse repository at this point
Copy the full SHA 635dc13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69f3899 - Browse repository at this point
Copy the full SHA 69f3899View commit details -
Make an evolve test not refer to reference resolution.
Just avoids a deprecation warning when we switch over.
Configuration menu - View commit details
-
Copy full SHA for 2889feb - Browse repository at this point
Copy the full SHA 2889febView commit details -
Move Validator._resolver to _ref_resolver.
Makes way for our newer resolver to live in the shorter name. (This should have no effect on the public API, where we have Validator.resolver returning this attribute after emitting a deprecation warning.) Also bumps the minimum attrs version we depend on, as we need the alias functionality.
Configuration menu - View commit details
-
Copy full SHA for a39e5c9 - Browse repository at this point
Copy the full SHA a39e5c9View commit details -
Resolve $ref using the referencing library.
Passes all the remaining referencing tests across all drafts, hooray! Makes Validators take a referencing.Registry argument which users should use to customize preloaded schemas, or to configure remote reference retrieval. This fully obsoletes jsonschema.RefResolver, which has already been deprecated in a previous commit. Users should move to instead loading schemas into referencing.Registry objects. See the referencing documentation at https://referencing.rtfd.io/ for details (with more jsonschema-specific information to be added shortly). Note that the interface for resolving references on a Validator is not yet public (and hidden behind _resolver and _validate_reference attributes). One or both of these are likely to become public after some period of stabilization. Feedback is of course welcome!
Configuration menu - View commit details
-
Copy full SHA for e826629 - Browse repository at this point
Copy the full SHA e826629View commit details -
Configuration menu - View commit details
-
Copy full SHA for a93e88b - Browse repository at this point
Copy the full SHA a93e88bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdda723 - Browse repository at this point
Copy the full SHA bdda723View commit details -
Configuration menu - View commit details
-
Copy full SHA for a42bbd9 - Browse repository at this point
Copy the full SHA a42bbd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd6a7d0 - Browse repository at this point
Copy the full SHA bd6a7d0View commit details -
<19.3 can have performance problems on 3.11 where there aren't wheels (and where I think it's falling back to using the pure- Python implementation even on CPython). Here it's ~2x slower.
Configuration menu - View commit details
-
Copy full SHA for 33e2882 - Browse repository at this point
Copy the full SHA 33e2882View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcea5ad - Browse repository at this point
Copy the full SHA fcea5adView commit details
Commits on Feb 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 34d19dc - Browse repository at this point
Copy the full SHA 34d19dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c4cd7c - Browse repository at this point
Copy the full SHA 8c4cd7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e922e79 - Browse repository at this point
Copy the full SHA e922e79View commit details
Commits on Feb 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 25f40e5 - Browse repository at this point
Copy the full SHA 25f40e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 787dbc9 - Browse repository at this point
Copy the full SHA 787dbc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3801d9a - Browse repository at this point
Copy the full SHA 3801d9aView commit details -
Three more exception-related deprecations.
* RefResolutionError is deprecated entirely. Use referencing.Registry-based APIs, and catch referencing.exceptions.Unresolvable if you really want to ignore referencing related issues. * FormatError should now be imported from jsonschema.exceptions only, not from the package root. * ErrorTree should now be imported from jsonschema.exceptions only, not from the package root.
Configuration menu - View commit details
-
Copy full SHA for 19bdf61 - Browse repository at this point
Copy the full SHA 19bdf61View commit details
Commits on Feb 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 84199e9 - Browse repository at this point
Copy the full SHA 84199e9View commit details
Commits on Mar 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eb00447 - Browse repository at this point
Copy the full SHA eb00447View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b547c7 - Browse repository at this point
Copy the full SHA 2b547c7View commit details -
Speed up Validator.evolve by pre-computing fields.
We're not a general class, so we know what fields we need ahead of time. This seems to give ~15% speedup on Validator evolution, which happens often as part of walking up and down schemas.
Configuration menu - View commit details
-
Copy full SHA for 94c60e4 - Browse repository at this point
Copy the full SHA 94c60e4View commit details
Commits on Mar 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1854b26 - Browse repository at this point
Copy the full SHA 1854b26View commit details
Commits on Mar 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4d6bff9 - Browse repository at this point
Copy the full SHA 4d6bff9View commit details
Commits on Mar 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fcbeced - Browse repository at this point
Copy the full SHA fcbecedView commit details