-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Cache reference lookups for subschemas #894
perf: Cache reference lookups for subschemas #894
Conversation
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
=======================================
Coverage 98.25% 98.26%
=======================================
Files 20 20
Lines 3152 3170 +18
Branches 423 426 +3
=======================================
+ Hits 3097 3115 +18
Misses 44 44
Partials 11 11
Continue to review full report at Codecov.
|
Another small thing that cuts the time to |
Ayy CPython... Yes that's likely fine with me too as long as we preserve the documentation! |
CHANGELOG.rst
Outdated
@@ -5,6 +5,7 @@ v4.3.0 | |||
certain input types (#893) | |||
* Cache reference lookups for subschemas (#893) | |||
* Use cached lookups for resolving fragments if the referent document is known (#893) | |||
* Replace the ``Validator.evolve`` method with an equivalent class attribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an implementation detail, we can save mentioning it I think.
And for the other two I'd maybe just say something simpler like "resolving refs has had performance improvements" and have that cover the whole change, someone can look at the PR for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! :)
Fantastic, thanks again, really appreciate the time! Merging. |
The latest commit cuts the time to 8.08942461013794 sec which is quite close to
3.2.0
version performance (5.38702654838562 sec on my machine)