Add LightEffect module for smart light strips #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #918 +/- ##
==========================================
+ Coverage 91.15% 91.19% +0.03%
==========================================
Files 78 80 +2
Lines 5156 5222 +66
Branches 1254 1265 +11
==========================================
+ Hits 4700 4762 +62
- Misses 362 364 +2
- Partials 94 96 +2 ☔ View full report in Codecov by Sentry. |
sdb9696
force-pushed
the
feat/light_strip_effect2
branch
from
4792ac1
to
7f092ff
Compare
rytilahti
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
light_strip_lighting_effectcomponents forsmartdevices. Uses a new list of effects captured from a L900 which are similar to theioteffects but include some additional properties and a few extra effects.Assumes that a device only implements
light_strip_lighting_effectorlight_effectbut not both. If this changes in the future a decision could be made to give one precedence over the other as the common module.