Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python base version to 3.7+ #130

Merged
merged 6 commits into from
Dec 24, 2021
Merged

Update Python base version to 3.7+ #130

merged 6 commits into from
Dec 24, 2021

Conversation

npradeep357
Copy link
Contributor

Updated Python version to 3.7+ as 3.6 came to end-of-life support. Updated tests
related to #128

@npradeep357
Copy link
Contributor Author

npradeep357 commented Dec 1, 2021

@ccordoba12, updated Python version to 3.7+ and removed python 3.6 slots on Github actions.
Please approve workflows

@npradeep357
Copy link
Contributor Author

npradeep357 commented Dec 2, 2021

@ccordoba12 or @krassowski or authors, I see issue in static code analysis checks but I think that's not related to this PR. It says validate JSON schema check failed. I just updated the static.yml to use python 3.7 but not sure what's happening?
Can someone point out to me what's the issue here.

image

Thank you

@npradeep357
Copy link
Contributor Author

Only difference is that the static checks now use py 3.7 instead of 3.6.
Will jsonschema won't work as is in 3.7? or Is there a syntax change?

@ccordoba12 ccordoba12 added this to the v1.4.0 milestone Dec 7, 2021
@ccordoba12
Copy link
Member

@krassowski, could you check what's happening with jsonchema?

@krassowski
Copy link
Contributor

I opened python-jsonschema/jsonschema#889. A workaround for now would be to pass an empty instance of settings schema (weather through standard input or from a file).

@ccordoba12
Copy link
Member

I opened python-jsonschema/jsonschema#889.

Thanks for your help @krassowski!

A workaround for now would be to pass an empty instance of settings schema (weather through standard input or from a file).

What do you mean by this?

@krassowski
Copy link
Contributor

I mean something like:

echo "{}" | jsonschema pylsp/config/schema.json

because an empty instance (empty settings) are acceptable, so they will pass validation.

Alternatively we could pin a 3.x version. Ether should solve the problem on the CI for now.

@npradeep357
Copy link
Contributor Author

Updated jsonschema test as mentioned by @krassowski. Now the tests pass.
@krassowski or @ccordoba12 can you please review and approve this PR.

Thank you

README.md Outdated Show resolved Hide resolved
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Copy link
Contributor

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! I don't know if we want to merge immediately or wait until the EOL of Python 3.6 (23 Dec 2021).

@krassowski
Copy link
Contributor

Merging as Python 3.6 reached EOL yesterday.

@krassowski krassowski merged commit 7b98f9f into python-lsp:develop Dec 24, 2021
@ccordoba12 ccordoba12 changed the title Update python base version to 3.7+ Update Python base version to 3.7+ Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants