Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report Flake8 errors with Error severity level #234

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Report Flake8 errors with Error severity level #234

merged 2 commits into from
Jun 30, 2022

Conversation

lcheylus
Copy link
Contributor

@lcheylus lcheylus commented Jun 30, 2022 •
edited
Loading

Error codes from Flake8 :

  • Fxxx : checks from PyFlakes => Error severity level
  • E999 : code for invalid AST => Error severity level
  • Exxx : checks from pydocstyle (syntax checks for PEP-8) => Warning severity level
  • Wxxx : checks from pydocstyle (syntax checks for PEP-8) => Warning severity level

Fixes #230
Fix PR #223

@lcheylus
Report Flake8 errors with Error severity level
2e9f230 
Error codes from Flake8 :
  - Fxxx : checks from PyFlakes => Error severity level
  - E999 : code for invalid AST => Error severity level
  - Exxx : checks from pydocstyle (syntax checks for PEP-8) => Warning
    severity level
  - Wxxx : checks from pydocstyle (syntax checks for PEP-8) => Warning
    severity level

Closes python-lsp#230
Fix PR python-lsp#223
@lcheylus
Fix tests for Flake8 plugin with Error severity level
9fa6b9a 
Error code Fxxx from Flake8 have now Error severity level.
@ccordoba12 ccordoba12 added this to the v1.5.0 milestone Jun 30, 2022
ccordoba12
ccordoba12 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lcheylus!

@ccordoba12 ccordoba12 merged commit 5b29eac into python-lsp:develop Jun 30, 2022
@nexplor nexplor mentioned this pull request Aug 27, 2022
Closed
@lcheylus lcheylus deleted the flake8-error branch October 6, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

Flake8 reports wrong severity level for code Fxxx
2 participants
@lcheylus @ccordoba12