-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for flake8 per-file-ignores #28
Add support for flake8 per-file-ignores #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you contribution @brandonwillard! Looks good to me, except for some minor comments.
0f58e7c
to
bc3d15e
Compare
adda517
to
aadb8a9
Compare
What is this |
That is a flaky test that is unrelated to this PR, I've just re ran the CIs |
Thanks @brandonwillard! |
When might this be released? I'm looking forward to using it in my editor. 😄 |
This PR implements quick and dirty support for flake8's
per-file-ignores
option.Changes to the
list
-type config parsing were necessary. Specifically, the parsing for multiline config settings, e.g.needed to be altered to allow for multiple commas on a single line, because
per-file-ignores
takes a multiline list containing file names and comma separated lists of errors to be ignored: