Fix symbols for non-existing (unsaved) files #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test for `textDocument/documentSymbols` of a non-existing (unsaved) file. The test fails as of this commit and is a regression test for issue python-lsp#301 [1]. [1] python-lsp#301
ccordoba12
reviewed
Nov 23, 2022
There was a problem hiding this comment.
Thanks @rear1019 for your help with this! I left a small comment for you, otherwise looks good to me.
Fix `textDocument/documentSymbols` returning an empty result for non-existing (unsaved) files: Do not use `os.path.samefile()` which accesses the file system to check if two file paths point to the same file. Just compare the file paths. (This basically reverts commit 40afab3.) This fixes issue python-lsp#301 [1]. [1] python-lsp#301
rear1019
force-pushed
the
fix_symbols_unsaved_file
branch
from
ec3ecd0
to
efc6821
Compare
ccordoba12
approved these changes
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #301 and commit message for details. Regression test included.
Fixes #301.