Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing lz4 is very slow #154

Closed
cgohlke opened this issue Nov 4, 2018 · 2 comments
Closed

Importing lz4 is very slow #154

cgohlke opened this issue Nov 4, 2018 · 2 comments

Comments

@cgohlke
Copy link

cgohlke commented Nov 4, 2018 •
edited
Loading

On my system (Windows 10 Pro WS, SSD, Python 3.7.1, 64 bit, ~1100 packages installed), importing lz4 is very slow (~3.8 seconds) due to importing pkg_resources in __init__.py, There are several issues regarding slow import of pkg_resources.
@jonathanunderwood
Copy link
Member

Thanks for the report - that doesn't sound good. To be sure that the diagnosis you give is correct, can you run the following:

python3.7 -X importtime -c 'import lz4' 2> lz4-imports.txt

and upload the lz4-imports.txt to the issue?

jonathanunderwood added a commit that referenced this issue Nov 4, 2018
@jonathanunderwood
Stop using pkg_resources to get version (issue #154)
2b89bf3
jonathanunderwood added a commit that referenced this issue Nov 4, 2018
@jonathanunderwood
Merge pull request #156 from python-lz4/development
2da59a2 
Fix slow import problem (issue #154) and some flake8 and test issues,
@jonathanunderwood
Copy link
Member

Have just cut a new release, 2.1.2 that removes usage of pkg_resources. I'll close this, but feel free to re-open if you're still seeing the problem with the new release.

@cgohlke cgohlke mentioned this issue Dec 4, 2019
Merged
@totaam totaam mentioned this issue Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgohlke @jonathanunderwood