Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! First off, thanks for the library, it's been quite handy 馃檪
The
LZ4FrameFile
abstraction is somewhat leaky/surprising in that it offers aflush
method, as expected of a file, but it doesn't actually flush compressed data as one may expect. The method is just inherited fromio.BufferedIOBase
and doesn't have special logic to handle LZ4.This PR introduces the missing logic so that calling
flush
correctly ensures the frame is completed and flushed to the underlying fp.I'm not particularly familiar with the concepts behind compression algorithms, so while this really just deals with the file interface, works on the cases I've tried, and passes tests, please do look at it critically and let me know if I missed something!