Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheel package of 0.5.0 on pypi.org contains extra files #47

Closed
pbasista opened this issue Jun 21, 2018 · 2 comments
Closed

Wheel package of 0.5.0 on pypi.org contains extra files #47

pbasista opened this issue Jun 21, 2018 · 2 comments

Comments

@pbasista
Copy link
Contributor

pbasista commented Jun 21, 2018

This wheel package of version 0.5.0 hosted on pypi.org contains extra files when compared to a wheel package generated locally from git tag 0.5.0 using python setup.py bdist_wheel command in a clean virtual environment. The full diff is here.

The extra files, for instance openapi_core/validators.py, were present in the repository before PR #25 was merged. They are present in the wheel package of 0.5.0, but not in the source package of 0.5.0.

This probably indicates an issue with generating the wheel packages, where the files from previously generated wheel packages are somehow included in the new wheel package as well. I think it should be investigated and resolved.

@domenkozar
Copy link
Contributor

@p1c2u could the wheel be deleted? It's causing issues with testing:

>   from openapi_core.wrappers.base import BaseOpenAPIRequest, BaseOpenAPIResponse
E   ModuleNotFoundError: No module named 'openapi_core.wrappers.base'; 'openapi_core.wrappers' is not a package

Since pytest imports wrappers.py first instead of wrappers/ package.

@p1c2u
Copy link
Collaborator

p1c2u commented Aug 23, 2018

@pbasista @domenkozar
0.5.0 was unfortunate version. I hope 0.6.0 will be much better. Thank you for your help. Cheers.

@p1c2u p1c2u closed this as completed Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants