Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional meta data to schema and errors #120

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add additional meta data to schema and errors #120

wants to merge 8 commits into from

Commits on Mar 8, 2019

  1. Store additional information in the schema (name and deref) and also … 

    …store schema in errors. This gives us the ability to provide additional context when an error occurs, for example if the schema is named then the name of the schema, or if the yaml is parsed with ruamel.yaml we can show the line and column number that generated the error.
    @danielbradburn
    danielbradburn committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    1592c18 View commit details
    Browse the repository at this point in the history

  2. added tests for InvalidFormat and InvalidSchema

    @danielbradburn
    danielbradburn committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    d776676 View commit details
    Browse the repository at this point in the history

  3. add newline to test_schemas.py

    @danielbradburn
    danielbradburn committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    e534f23 View commit details
    Browse the repository at this point in the history

  4. ensure that all changes to raising errors are covered by tests

    @danielbradburn
    danielbradburn committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    bddc61e View commit details
    Browse the repository at this point in the history

  5. fix linter errors

    @danielbradburn
    danielbradburn committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    b7f2e33 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. added simple test that checks that each schema Exception type can be … 

    …converted to a string without error
    @danielbradburn
    danielbradburn committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    4456f58 View commit details
    Browse the repository at this point in the history

  2. actually instantiate exception_type in exception test

    @danielbradburn
    danielbradburn committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    df697c9 View commit details
    Browse the repository at this point in the history

  3. removed unused import

    @danielbradburn
    danielbradburn committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    9969e6c View commit details
    Browse the repository at this point in the history