Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-disable Codecov PR comments #4394

Closed
hugovk opened this issue Jan 28, 2020 · 7 comments
Closed

Re-disable Codecov PR comments #4394

hugovk opened this issue Jan 28, 2020 · 7 comments

Comments

@hugovk
Copy link
Member

hugovk commented Jan 28, 2020

It should have been disabled by #4386, and there was no comment in that PR, but it's still commenting new PRs (#4391 (comment)).

@hugovk
Copy link
Member Author

hugovk commented Jan 28, 2020

@hugovk
Copy link
Member Author

hugovk commented Feb 9, 2020

Nearly two weeks and no reply in the Codecov support forum.

Another option is to disable it for all python-pillow repos via the "team yaml":

https://docs.codecov.io/docs/codecov-yaml#section-team-yaml

But I don't have access to https://codecov.io/account/gh/python-pillow/yaml

Only team owners may adjust this file.

@hugovk
Copy link
Member Author

hugovk commented Feb 13, 2020

Actually, looks like it's fixed, the last few PRs haven't received bot comments.

@radarhere
Copy link
Member

Thanks for asking codecov. I guess we'll see how this goes.

@radarhere radarhere reopened this Feb 16, 2020
@radarhere
Copy link
Member

#4423 seems to demonstrate that this is still an issue.

@hugovk
Copy link
Member Author

hugovk commented Mar 5, 2020

Codecov have a possible fix now, let's see if it happens again:

I located the comment. I suspect what happened was Codecov detected that the PR already had a comment and thus ignored the the setting in the YAML. It tried to edit it, failed, and created a new one.

We have a new notify task that we are slowly rolling out that probably handles this better. I have whitelisted you for this, please give us 15-30 mins for the pods to roll and then let me know if you continue to see this behavior.

https://community.codecov.io/t/prs-are-commented-even-with-comment-off/941/9?u=hugovk

@hugovk
Copy link
Member Author

hugovk commented Mar 19, 2020

Actually, looks like it's fixed, the last few PRs haven't received bot comments.

And again!

@hugovk hugovk closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants