Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace distutils.version with packaging.version.parse #4797

Merged
merged 1 commit into from Jul 18, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 16, 2020

For #4796.

Changes proposed in this pull request:

  • distutils will eventually be removed from the stdlib
  • Replace distutils.version with packaging.version.parse
  • packaging.version.parse is a third-party utility but is used by setuptools (so you probably already have it installed) and is conformant to the current PEP 440; it will return a packaging.version.Version if the version is compliant and a packaging.version.LegacyVersion if not. The latter will always sort before valid versions.

  • https://stackoverflow.com/a/11887885/724176

@radarhere
Copy link
Member

Thanks

@radarhere radarhere merged commit b243a61 into python-pillow:master Jul 18, 2020
@hugovk hugovk deleted the rm-distutils.version branch July 19, 2020 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants