Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced distutils in test_image_access.py #4814

Merged
merged 2 commits into from Jul 29, 2020

Conversation

radarhere
Copy link
Member

For #4796, similar to #4809

Replaces

from distutils import sysconfig

with

import sysconfig

and

sysconfig.get_python_inc()

with

sysconfig.get_config_var("INCLUDEPY")

Also removes a print statement.

However, this test is skipped on CIs, so this PR passing is not good evidence that my changes are correct. Instead, I created radarhere@73f8d40 to check that the values with and without distutils are the same - passing on AppVeyor and MSYS2 MINGW32.

@radarhere
Copy link
Member Author

In a move that's up for debate, I've added another commit, so that distutils is no longer explicitly imported - instead, I'm importing the distutils function from where it is imported in setuptools.

@radarhere radarhere changed the title Replaced distutils sysconfig in test_image_access.py Replaced distutils in test_image_access.py Jul 26, 2020
@hugovk hugovk merged commit 48c7d84 into python-pillow:master Jul 29, 2020
@hugovk
Copy link
Member

hugovk commented Jul 29, 2020

Thank you!

@hugovk hugovk mentioned this pull request Jul 29, 2020
@radarhere radarhere deleted the sysconfig branch July 29, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants