Raise proper TypeError in putpixel #4882
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4876:
OverflowError
for 8bpp images, hoping that the int will become a tuple in the next few lines.SystemError: new style getargs format but argument is not a tuple
.I;16
) gives an even less useful messageSystemError: <method 'putpixel' of 'ImagingCore' objects> returned NULL without setting an error
.This PR resolves all of these issues by explicitly raising a TypeError if the parameter can't be converted to an int, or a tuple for an 8bpp image.