Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImagingEffectSpread: 0 division error #4906

Closed
ghost opened this issue Sep 7, 2020 · 1 comment · Fixed by #4908
Closed

ImagingEffectSpread: 0 division error #4906

ghost opened this issue Sep 7, 2020 · 1 comment · Fixed by #4908
Labels
Bug Any unexpected behavior, until confirmed feature.

Comments

@ghost
Copy link

ghost commented Sep 7, 2020

Pillow/src/libImaging/Effects.c

Line 136 in 4634eaf

int xx = x + (rand() % distance) - distance/2;\

distance value is not checked in this function. So if distance value is 0 then happen 0 division error.
Need check this variable value before expression.
@radarhere radarhere changed the title ImageEffectSpread: 0 division error ImagingEffectSpread: 0 division error Sep 8, 2020
@radarhere radarhere added the Bug Any unexpected behavior, until confirmed feature. label Sep 8, 2020
@radarhere radarhere mentioned this issue Sep 8, 2020
Merged
@radarhere
Copy link
Member

Thanks for reporting this. I've created PR #4908 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Any unexpected behavior, until confirmed feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed effect_spread bug for zero distance radarhere/Pillow
1 participant
@radarhere