Fixed incorrect operator in ImageCms error #6370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Please could you add a test for this? And let's also use an f-string. |
|
You are welcome. This bugs was found by our automated tool statically. I am not familiar with the codebase so it would be difficult for me to write a test case. |
|
That's fine, I've added tests, thanks! |
radarhere
reviewed
Jun 19, 2022
We get "an integer is required (got type NoneType)" with Python 3.7-3.9 on Windows. We get "'NoneType' object cannot be interpreted as an integer" with Python 3.10 on Windows and all versions on macOS and Ubuntu.
hugovk
changed the title
radarhere
reviewed
Jun 19, 2022
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
approved these changes
Jun 19, 2022
radarhere
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request is a fix to a potential wrong operator bug at
src/PIL/ImageCms.py. Please check the changes.Best,
Jingxuan