Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added signed option when saving JPEG2000 images #6709

Merged
merged 3 commits into from
Dec 29, 2022

Conversation

radarhere
Copy link
Member

Resolves #5502

Allows

im.save(outfile, signed=True)

to save JPEG2000 sgnd images.

@hugovk
Copy link
Member

hugovk commented Dec 28, 2022

Shall we do it as a keyword-only argument? So it can be called like:

im.save(outfile)
im.save(outfile, signed=True)
im.save(outfile, signed=False)

But not:

im.save(outfile, True)
im.save(outfile, False)

That should make things clearer, no need to wonder what True or False mean here.

@hugovk
Copy link
Member

hugovk commented Dec 28, 2022

And let's add this to the release notes.

@radarhere
Copy link
Member Author

It should already be a keyword-only argument, as is the rule for encoderinfo keys.

I've added release notes.

@hugovk hugovk merged commit f452f9a into python-pillow:main Dec 29, 2022
@hugovk
Copy link
Member

hugovk commented Dec 29, 2022

Thanks!

@radarhere radarhere deleted the signed branch December 29, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exposing the OpenJPEG sgnd parameter when JPEG2000 encoding
2 participants