Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ImageFont.getsize and related functions for Pillow 10.0.0 #7080

Merged
merged 7 commits into from Apr 10, 2023

Conversation

radarhere
Copy link
Member

This removes functions deprecated in #6381.

It includes

Comment on lines 15 to 16
.. _Font size and offset methods:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit should be moved down as well.

Or, does Sphinx automatically create this anchor, and can we remove it?

Suggested change
.. _Font size and offset methods:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchor was only being used from ImageDraw documentation that needed to be removed.

I've pushed a commit to remove both.

@radarhere
Copy link
Member Author

The Ubuntu failures are also happening on main - https://github.com/python-pillow/Pillow/actions/runs/4656595509

@hugovk
Copy link
Member

hugovk commented Apr 10, 2023

Tests/test_qt_image_qapplication.py::test_sanity Fatal Python error: Aborted

PyQt6 6.5.0 was released two hours ago: https://pypi.org/project/PyQt6/6.5.0/

@hugovk hugovk added the automerge Automatically merge PRs that are ready label Apr 10, 2023
@radarhere
Copy link
Member Author

#7081 was merged as a temporary workaround for the Qt failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PRs that are ready Removal Removal of a feature, usually done in major releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants