Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading signed 8-bit TIFF images #7111

Merged
merged 2 commits into from May 4, 2023
Merged

Conversation

radarhere
Copy link
Member

Resolves #811 using the suggested code.

Test image was created with a modified Pillow.

@hugovk
Copy link
Member

hugovk commented May 3, 2023

Let's add this to the release notes.

@radarhere
Copy link
Member Author

This is not completely simple, because there are a variety of specific settings in OPEN_INFO.

I've adjusted the code to also support both ByteOrders, and presumed that I don't need to mention that there aren't any ExtraSamples supported and that FillOrder 2 isn't supported since "FillOrder=2 is not required in Baseline TIFF compliant readers".

So the release notes read

Support reading signed 8-bit TIFF images
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

TIFF images with signed integer data, 8 bits per sample and a photometric interpretaton of BlackIsZero can now be read.

@hugovk hugovk merged commit 1e7c77c into python-pillow:main May 4, 2023
59 checks passed
@radarhere radarhere deleted the tiff branch May 4, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to open OME-TIFF example data files
2 participants