Do not use CFFI access by default on PyPy #7236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
added
Performance
Deprecation
Closed
hugovk
reviewed
Jun 28, 2023
docs/deprecations.rst
Outdated
|
|
||
| Since Pillow's C API is now faster than PyAccess on PyPy, | ||
| :py:mod:`~PIL.PyAccess` has been deprecated and will be removed in Pillow | ||
| 11.0.0 (2024-10-15). |
There was a problem hiding this comment.
And mention the C API is now used by default?
(And in docs/releasenotes/10.0.0.rst)
hugovk
approved these changes
Jun 28, 2023
|
I've updated the documentation to similarly deprecate Unfortunately, from https://discuss.python.org/t/extend-pep-562-with-setattr-for-modules/25506 it looks like it is not possible to override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7223
Pillow's C API is now faster than PyAccess on PyPy. However, PyAccess is part of our public API, so it can't be removed immediately.
This PR makes two changes.
Image.USE_CFFI_ACCESSis set toFalse, even on PyPy, allowing the faster C API to be used by default. If users do setImage.USE_CFFI_ACCESStoTruemanually, then they will find that...