-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot install 2.5.0 on Ubuntu 14.04 #790
Comments
Weird, works for me:
|
Ok so downloaded the tarball and setup.py install fails too, but:
|
@xrmx Weird OK thanks @wiredfool will have to take a look |
@unbit tracked the issue due to multiprocessing module not working because of missing /dev/shm and we are going to add shm to our environment. It looks like am not the only one with the issue though, see http://stackoverflow.com/questions/6033599/oserror-38-errno-38-with-multiprocessing, so would be cool to stop monkey patching if multiprocessing is found broken. |
@xrmx Can you please clarify why you refer to the multiprocessing code as a "monkey patch"? I'm not familiar with that code… other than its goal to "make tests go faster". |
I'll get that fixed. @aclark4life https://github.com/python-pillow/Pillow/blob/master/mp_compile.py#L1 |
Ok, fixed that in #791. |
Going to leave this open until the next release |
OK so you monkey patch the
Just curious. |
This was the cleanest way that I could figure out how to do it at the time. There are several compiler classes currently, depending on platforms, and the only way to hook into them was to get between them and the base class, or modify the base class. The compiler classes tend to be somewhat orthogonal to what I was doing, they're worried about correctness of how to compile, and I'm worried about how many compilers I can have going at once. The base is the choke point, so that's where I went. |
Thanks! Looks good, will give it a try tomorrow. Any timeline for a 2.5.1 release? |
@xrmx After you test we can cherry pick the fix into the 2.5.x branch and make a release. |
@aclark4life i've tested right now: |
Great, thanks. @wiredfool you want to cherry pick? |
Yeah. Anything else that should go into it? [edit] I think the 32bit segfault patch too. |
@wiredfool Sure whatever you think is best. CC: @hugovk Got anything for a 2.5.1 release? I only want to include what must be included. |
@aclark4life Nope, no musts from me for 2.5.1. |
PR #792 sent. |
And released: https://pypi.python.org/pypi/Pillow/2.5.1 |
Pillow 2.4.0 works fine, virtualenv 1.11.4, python 2.7.6
gives:
The text was updated successfully, but these errors were encountered: