Add CentOS Stream 8 #119
Merged
Add CentOS Stream 8 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
force-pushed
the
add-centos-stream-8
branch
from
b9e7340
to
d6fc090
Compare
radarhere
reviewed
Sep 17, 2021
| && /vpy3/bin/pip install --no-cache-dir numpy --only-binary=:all: || true \ | ||
| && chown -R pillow:pillow /vpy3" | ||
|
|
||
| COPY depends /depends |
There was a problem hiding this comment.
Suggested change
| COPY depends /depends | |
| ADD depends /depends |
Any reason why this is COPY, when every other file uses ADD? It still passes with ADD - https://github.com/radarhere/docker-images/runs/3631282199
There was a problem hiding this comment.
It's a best practice:
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy
I didn't change other files, they can be updated when they're changed, or left until archived. But can easily do a quick sweep now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS is changing their release model.
After CentOS 8 comes CentOS Stream 8, and later CentOS Stream 9.
centos-stream-8-amd64is based oncentos-8-amd64.