Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added manylinux_2_28 wheel build #182

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

radarhere
Copy link
Member

Adds a manylinux_2_28 wheel build, on top of our current manylinux2014 wheel build.

With that, we have both of manylinux image types we use in pillow-wheels and both of the non-EOL manylinux images from https://github.com/pypa/manylinux#docker-images.

@radarhere radarhere changed the title Added manylinux_2_24 wheel build Added manylinux_2_28 wheel build May 30, 2023
@hugovk
Copy link
Member

hugovk commented May 30, 2023

What's the purpose of this, to help manual testing? Do we need both manylinux2014 and manylinux_2_28?

@radarhere
Copy link
Member Author

https://github.com/python-pillow/docker-images/blob/main/manylinux2014-wheel-build/README.md states

This image is a little different than the other images in this repo -- it's intended to be a quick way to build manylinux wheels with the production version of the libraries for debugging and testing purposes.

So yes, manual testing. I would imagine that having both would help test in different environments.

@hugovk hugovk merged commit 93224aa into python-pillow:main May 30, 2023
21 checks passed
@hugovk
Copy link
Member

hugovk commented May 30, 2023

Okay, merged! This repo has some very slow jobs, this is among the quicker at "only" 13 minutes and luckily we don't need to build this repo too often:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants