Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis builds #398

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Fix Travis builds #398

merged 2 commits into from
Aug 15, 2023

Conversation

radarhere
Copy link
Member

The Travis builds have started failing.

The last successful run of Travis was on July 10.
The first failing run on main was on July 30, with the error

docker: invalid reference format: repository name must be lowercase.

Now, you would think that this is because our repository is named "Pillow".

However, if I switch to "pillow", then the error becomes

Unable to find image 'pillow:latest' locally

docker appears to be trying to find a docker image named "pillow". What I surmise is happening is that when build_wheel passes"build_wheel Pillow" to $build_cmds, docker thinks that "Pillow" is the name of the docker image. It has stopped understanding that the space in the middle does not mean that "BUILD_COMMANDS" is finished, and thinks "Pillow" is a separate argument.

For some reason, this problem doesn't occur in our GitHub Actions builds, or in #367, which continue to pass. So I don't know what has caused docker to behave like this in Travis.

I have found that two changes can workaround this problem.

Unable to find image 'pytest-timeout:latest' locally

So I have also changed TEST_DEPENDS from "pytest pytest-timeout" to "pytest-timeout"

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun! Thanks for the fix!

@hugovk hugovk added the automerge Automatically merge PRs that are ready label Aug 15, 2023
@mergify mergify bot merged commit e09fab7 into python-pillow:main Aug 15, 2023
68 checks passed
@radarhere radarhere deleted the travis branch August 15, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PRs that are ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants