Fix unicode error #136
Closed
Fix unicode error #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes python-poetry#221 by exchanging the regex package for re (the former having fixed the long-standing bug in re (see [here](lark-parser/lark#590) for details). Not sure if this will work for poetry (i.e., whether adding regex as a dependency is acceptable)...but thought I would propose this change and wait for feedback to take it from there. Thanks!
|
Thank you for the PR! Can you rebase against main and resolve the conflicts? |
* Update CI files for Python 3.6+ only * Modernize codebase * Reorganize imports to improve performance
The sync target previously regenerated the poetry.lock for vendored packages, causing larger than necessary change set for patches. This change introduces the update target to specifically handle lock file updates, lock target to regenerate the lock file and repurpose the sync target to only sync as expected.
Setting develop to `True` by default causes un-expected side-effects and requires downstream consumers to rely on checks like `package.develop and package.source_type == "directory""` to determine if develop mode. This also corresponds to current high-level behaviour of packages being non-develop by default.
|
Thanks @stephsamson ! I rebased, added failing tests, and pushed again (all local tests passing with latest commit). Please do let me know what else would be needed. |
|
P.S. I just reformatted. It currently seems to fail because regex is missing as a dependency; do you happen to know where I should specify it? (Would adding it to |
|
Superseded by #276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #221 by exchanging the regex package for re (the former having fixed the long-standing bug in re (see here for details). Not sure if this will work for poetry (i.e., whether adding regex as a dependency is acceptable)...but thought I would propose this change and wait for feedback to take it from there.
Thanks!
Resolves: python-poetry/poetry#221
Unfortunately couldn't figure out where to add the tests. Let me know and I will gladly do so!