Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python 3.6 #263

Merged
merged 18 commits into from Feb 3, 2022
Merged

Conversation

tony
Copy link
Contributor

@tony tony commented Jan 16, 2022

Resolves: python-poetry/poetry#4997
See also: python-poetry/poetry#5055, python-poetry/install.python-poetry.org#11

As I'm getting acclimated with the code base, this may have some back and forth to it

  • Added tests for changed code.
  • Updated documentation for changed code.

Later?

Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tony, couple suggestions

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests/testutils.py Outdated Show resolved Hide resolved
src/poetry/core/utils/_compat.py Outdated Show resolved Hide resolved
@neersighted neersighted self-assigned this Jan 25, 2022
danieleades
danieleades previously approved these changes Jan 25, 2022
danieleades
danieleades previously approved these changes Jan 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tony
Copy link
Contributor Author

tony commented Jan 29, 2022

@neersighted can this have tests ran on them?

Is it possible to allow tests to always run for me?

@tony tony requested a review from danieleades January 29, 2022 12:04
@tony
Copy link
Contributor Author

tony commented Jan 29, 2022

in re:

@tony tony dismissed danieleades’s stale review via 4bb19c9 1 minute ago

@danieleades Just a rebase against master

@neersighted
Copy link
Member

@neersighted can this have tests ran on them?

Is it possible to allow tests to always run for me?

There is no manual whitelist. Having a merged PR will automatically run CI for you in the future.

@finswimmer finswimmer merged commit 98793c8 into python-poetry:master Feb 3, 2022
@tony tony deleted the deprecate-python-3.6 branch February 5, 2022 20:12
@finswimmer finswimmer mentioned this pull request Feb 9, 2022
DavidVujic pushed a commit to DavidVujic/poetry-core that referenced this pull request Mar 26, 2022
* Vendors: Bump min python 3.6 -> 3.7

* ci: Remove python 3.6

* ci[pre-commit]: Update pyupgrade arg 3.6 -> 3.7

* chore(flake8): Add min_python_version

* deps(pyproject): Bump minimum python 3.6 -> 3.7

* deps: Remove PEP 557 (dataclasses) backport for 3.6

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* chore(tox): remove python 3.6

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* chore: Remove PY36

* CI(integration): Remove 3.6

* chore(testutils.py): Unused args

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* build(deps): Simplify isort markers

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* build(deps): Simplify pre-commit marker

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* chore: Cleanup unused condition, import

* chore: Remove PY37 checks (unused)

* chore: Fix codesmell

See also: https://sonarcloud.io/project/issues?id=poetry-core&open=AX5towEhmZqnEonFAx80&pullRequest=263&resolved=false&types=CODE_SMELL

* chore: Remove FileNotFoundError

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
* Vendors: Bump min python 3.6 -> 3.7

* ci: Remove python 3.6

* ci[pre-commit]: Update pyupgrade arg 3.6 -> 3.7

* chore(flake8): Add min_python_version

* deps(pyproject): Bump minimum python 3.6 -> 3.7

* deps: Remove PEP 557 (dataclasses) backport for 3.6

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* chore(tox): remove python 3.6

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* chore: Remove PY36

* CI(integration): Remove 3.6

* chore(testutils.py): Unused args

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* build(deps): Simplify isort markers

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* build(deps): Simplify pre-commit marker

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* chore: Cleanup unused condition, import

* chore: Remove PY37 checks (unused)

* chore: Fix codesmell

See also: https://sonarcloud.io/project/issues?id=poetry-core&open=AX5towEhmZqnEonFAx80&pullRequest=263&resolved=false&types=CODE_SMELL

* chore: Remove FileNotFoundError

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants