packages: unify python project check #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
force-pushed
the
unifiy-python-project-check
branch
from
c5350b2
to
70ad2cc
Compare
neersighted
requested changes
May 26, 2022
| def is_installable_dir(path: str) -> bool: | ||
| """Return True if `path` is a directory containing a setup.py file.""" | ||
| if not os.path.isdir(path): | ||
| @functools.lru_cache(maxsize=None) |
There was a problem hiding this comment.
I'm curious how much of a hot path this is/if caching is a significant benefit here?
There was a problem hiding this comment.
My thinking is this is called every time a dir dependency gets cloned, this happens a few times during resolution. And since this requires IO figured it can't hurt.
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
|
Kudos, SonarCloud Quality Gate passed!
|
neersighted
approved these changes
May 31, 2022
Merged
bostonrwalker
pushed a commit
to bostonrwalker/poetry-core
that referenced
this pull request
Aug 29, 2022
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #368 in relation to python-poetry/poetry#5692
Seems we were only checking for
setup.pywhen determining if a relative path dependency was installable.