Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make poetry check detect missing authors property #437

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Make poetry check detect missing authors property #437

merged 4 commits into from
Aug 22, 2022

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented Aug 3, 2022 •
edited
Loading

Resolves: python-poetry/poetry#4303

  • Added tests for changed code.

Changes:

  • Updated the poetry-schema.json to add authors to the 'required' section
  • Updated tests as required

Note that python-poetry/poetry#6112 must be merged before the downstream tests for this PR will pass.

@stinodego stinodego mentioned this pull request Aug 3, 2022
Merged
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Secrus Secrus merged commit c9348e8 into python-poetry:main Aug 22, 2022
@Secrus Secrus mentioned this pull request Aug 22, 2022
Closed
2 tasks
@finswimmer finswimmer mentioned this pull request Aug 26, 2022
Merged
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
@stinodego @Secrus @bostonrwalker
Make poetry check detect missing authors property (python-poetry#437
55e070d 
)

* Add authors as required property

* Fix existing tests

Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Secrus Secrus Secrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@stinodego @Secrus