Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add authors to required fields #99

Closed
wants to merge 4 commits into from
Closed

Add authors to required fields #99

wants to merge 4 commits into from

Conversation

abitrolly
Copy link

@abitrolly abitrolly commented Oct 9, 2020 •
edited
Loading

Relates-to: python-poetry/poetry#407
Relates-to: python-poetry/poetry#3155

UPDATE: I see this is a duplicate of #37 Let me add tests to it.

@abitrolly
Copy link
Author

Unable to run tests, because poetry install fails. Looking into this.

$ poetry install
The lock file might not be compatible with the current version of Poetry.
Upgrade Poetry to ensure the lock file is read properly or, alternatively, regenerate the lock file with the `poetry lock` command.
Installing dependencies from lock file

[RecursionError]
maximum recursion depth exceeded while calling a Python object

@abitrolly abitrolly force-pushed the patch-1 branch 2 times, most recently from 6797a10 to 3604970 Compare October 10, 2020 17:36
@abitrolly
Copy link
Author

@python-poetry/triage this is ready for review.

@finswimmer finswimmer requested a review from a team October 11, 2020 06:24
@abitrolly
Copy link
Author

This is hacktoberfest related PR. Any chance to get it merged before the deadline? Pretty please. :D

@luni3359
Copy link

luni3359 commented Sep 26, 2021 •
edited
Loading

While this is now in the documentation, poetry check still incorrectly marks the pyproject.toml file as correct even if the authors key is missing.

@abitrolly
Copy link
Author

abitrolly commented Sep 27, 2021 •
edited
Loading

The indentation in 44167a5 made this PR unmergeable. I am looking for a way to fix this.

Ryan Delaney and others added 4 commits September 27, 2021 13:56
@abitrolly
Add "authors" as a required field in config schema
9dea02e 
Before this change, a pyproject.toml file without an "authors" field
would throw an unhandled `NonExistentKey` exception. Now it will be
returned as a config validation error, as with the "name", "version",
and "description" fields.
@abitrolly
Add test for missing authors and fix broken
0c641dc
@abitrolly
Fix string comparison for Python 2
0ba8881
@abitrolly
Use partial string matching in schema validation assert
f3a56e6 
This makes it Python 2 and Python 3 compatible

See python-jsonschema/jsonschema#751
@abitrolly
Copy link
Author

Rebased and ready for review again.

@mkniewallner mkniewallner mentioned this pull request Jan 6, 2022
Closed
3 tasks
@Secrus
Copy link
Member

Secrus commented Aug 22, 2022

Superseeded by #437

@Secrus Secrus closed this Aug 22, 2022
@abitrolly
Copy link
Author

Stealing PRs is unfair! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
4 participants
@abitrolly @luni3359 @Secrus @abn