Port over bugfixes from poetry 1.0.x branch

poetry/core/packages/package.py

@@ -172,6 +172,12 @@ def _get_author(self):  # type: () -> dict
 
         m = AUTHOR_REGEX.match(self._authors[0])
 
+        if m is None:
+            raise ValueError(
+                "Invalid author string. Must be in the format: "
+                "John Smith <john@example.com>"
+            )
+
         name = m.group("name")
         email = m.group("email")
 
@@ -183,6 +189,12 @@ def _get_maintainer(self):  # type: () -> dict
 
         m = AUTHOR_REGEX.match(self._maintainers[0])
 
+        if m is None:
+            raise ValueError(
+                "Invalid maintainer string. Must be in the format: "
+                "John Smith <john@example.com>"
+            )
+
         name = m.group("name")
         email = m.group("email")
 

poetry/core/vcs/git.py

@@ -197,7 +197,7 @@ def config(self):  # type: () -> GitConfig
         return self._config
 
     def clone(self, repository, dest):  # type: (...) -> str
-        return self.run("clone", repository, str(dest))
+        return self.run("clone", "--recurse-submodules", repository, str(dest))
 
     def checkout(self, rev, folder=None):  # type: (...) -> str
         args = []

tests/packages/test_package.py

@@ -18,6 +18,19 @@ def test_package_authors():
     assert package.author_email is None
 
 
+def test_package_authors_invalid():
+    package = Package("foo", "0.1.0")
+
+    package.authors.insert(0, "<John Doe")
+    with pytest.raises(ValueError) as e:
+        package.author_name
+
+    assert (
+        str(e.value)
+        == "Invalid author string. Must be in the format: John Smith <john@example.com>"
+    )
+
+
 @pytest.mark.parametrize("category", ["main", "dev"])
 def test_package_add_dependency_vcs_category(category):
     package = Package("foo", "0.1.0")