Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create homebrew formula for poetry #1765

Closed
2 tasks done
AlJohri opened this issue Dec 18, 2019 · 4 comments
Closed
2 tasks done

create homebrew formula for poetry #1765

AlJohri opened this issue Dec 18, 2019 · 4 comments
Labels
kind/feature Feature requests/implementations

Comments

@AlJohri
Copy link

AlJohri commented Dec 18, 2019

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Linking Past Issues:

Feature Request

I would like to create a poetry homebrew formula for poetry 1.0. Before proceeding, I want to confirm that if I create this formula it would be one of the officially sanctioned ways of installing poetry (for macOS) and documented in the Installation section.

Thanks!

@AlJohri AlJohri added the kind/feature Feature requests/implementations label Dec 18, 2019
@chenrui333
Copy link
Contributor

Just FYI, I have merged the poetry 1.0.0 PR. Let me know if you run into any issue.

@lithammer
Copy link

Seems like it's suffering from this: Homebrew/homebrew-core#48883

br3ndonland added a commit to br3ndonland/dotfiles that referenced this issue Oct 19, 2021
1d8eee0
884d475

Poetry has a new install script, install-poetry.py, which alters the
requirements for adding Poetry to `$PATH`. `$HOME/.local/bin` was
already on `$PATH` for pipx, so it seemed like a good option. Commits
1d8eee0 and 884d475 updated `.zshrc` and `script/strap-after-setup` for
install-poetry.py and `POETRY_HOME=$HOME/.local`.

This made sense initially, because Poetry installs its binaries into
`$POETRY_HOME/bin`, and because Poetry doesn't have a `$POETRY_BIN_DIR`
configuration variable like pipx does (`$PIPX_BIN_DIR`). Unfortunately,
`POETRY_HOME=$HOME/.local` ended up being problematic, because Poetry
takes over `$POETRY_HOME`, and doesn't consider other applications
installed there. For example, if the get-poetry.py or install-poetry.py
scripts were used to install Poetry, they can also be used to uninstall
Poetry. Uninstalling with `python install-poetry.py --uninstall` or
`python get-poetry.py --uninstall` deletes the entire `$POETRY_HOME`
directory, which means it deletes `$HOME/.local`, causing problems for
other applications that use `$HOME/.local` (python-poetry/poetry#4625).

There have been many other issues with the Poetry custom install scripts
get-poetry.py and install-poetry.py (br3ndonland/inboard#36), so other
installation methods are be welcome.

Poetry is now available through Homebrew, but Homebrew installation is
not supported by the Poetry maintainers. Homebrew installation also
requires its own custom install script, which creates its own issues.
python-poetry/poetry#941
python-poetry/poetry#1765
Homebrew/homebrew-core#48883
Homebrew/homebrew-core#86776

pipx (https://pypa.github.io/pipx/) can also be used to install Poetry.
The pipx installation method is suggested in the Poetry docs and GitHub,
and pipx is already in use in this repo.
python-poetry/poetry#677
python-poetry/poetry#3360

This commit will remove `export POETRY_HOME=$HOME/.local` from `.zshrc`,
and will install Poetry with pipx.
@Secrus
Copy link
Member

Secrus commented May 23, 2022

The Poetry team decided against providing system/distro-specific installers for Poetry. Currently supported are the official installation script, pip, and pipx. Other methods are not officially supported and probably won't be for a foreseeable future.

@Secrus Secrus closed this as completed May 23, 2022
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants