Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This locked is assigned but not used? #4961

Closed
2 tasks done
Anselmoo opened this issue Dec 31, 2021 · 1 comment · Fixed by #4962
Closed
2 tasks done

This locked is assigned but not used? #4961

Anselmoo opened this issue Dec 31, 2021 · 1 comment · Fixed by #4962

Comments

@Anselmoo
Copy link
Contributor

Anselmoo commented Dec 31, 2021 •
edited
Loading

  • I am on the latest Poetry version. macOS Poetry version 1.1.12
  • I have searched the issues of this repo and believe that this is not a duplicate.

poetry/src/poetry/puzzle/solver.py

Lines 97 to 99 in 5814e33

locked = {}
for package in self._locked.packages:
locked[package.name] = DependencyPackage(package.to_dependency(), package)

@Anselmoo Anselmoo changed the title This locked is assigned but not used_ This locked is assigned but not used? Dec 31, 2021
Anselmoo added a commit to Anselmoo/poetry that referenced this issue Dec 31, 2021
@Anselmoo
Ideas for refactoring
0e6e66d 
And also refering to issue python-poetry#4961
@Anselmoo Anselmoo mentioned this issue Dec 31, 2021
Merged
2 tasks
finswimmer pushed a commit that referenced this issue Jan 1, 2022
@Anselmoo
Ideas for refactoring (#4962)
1aa4d5b 
* Ideas for refactoring

And also refering to issue #4961

* Respond to the review

Removed items() from os.environ and add blank lines

* Add link.is_wheel back
@finswimmer finswimmer linked a pull request Jan 1, 2022 that will close this issue
Ideas for refactoring #4962
Merged
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ideas for refactoring Anselmoo/poetry
2 participants
@finswimmer @Anselmoo