Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ideas for refactoring #4962

Merged
merged 3 commits into from
Jan 1, 2022
Merged

Ideas for refactoring #4962

merged 3 commits into from
Jan 1, 2022

Conversation

Anselmoo
Copy link
Contributor

I saw that there Refactor-label, so I took a closer look and had the following suggestions.

And also referring to issue #4961

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

@Anselmoo
Ideas for refactoring
0e6e66d 
And also refering to issue python-poetry#4961
finswimmer
finswimmer requested changes Jan 1, 2022
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot and a happy new year 👍

I just add some small suggestions and one questions.

I wonder how you find the parts to refactor?

src/poetry/utils/env.py Outdated Show resolved Hide resolved
src/poetry/utils/env.py Outdated Show resolved Hide resolved
src/poetry/utils/env.py Outdated Show resolved Hide resolved
src/poetry/installation/chef.py Outdated Show resolved Hide resolved
src/poetry/mixology/incompatibility.py Show resolved Hide resolved
src/poetry/mixology/incompatibility.py Outdated Show resolved Hide resolved
src/poetry/utils/env.py Show resolved Hide resolved
@Anselmoo
Copy link
Contributor Author

Anselmoo commented Jan 1, 2022

Thanks a lot and a happy new year 👍

I just add some small suggestions and one questions.

I wonder how you find the parts to refactor?

Thank you @finswimmer! Wish you also a pleasant year.

Concerning the general question, about how to find the reactors.

@Anselmoo
Respond to the review
da33b75 
Removed items() from os.environ and add blank lines
Anselmoo
Anselmoo commented Jan 1, 2022
View reviewed changes
Copy link
Contributor Author

@Anselmoo Anselmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes added

finswimmer
finswimmer requested changes Jan 1, 2022
View reviewed changes
src/poetry/installation/chef.py Outdated Show resolved Hide resolved
@finswimmer
Copy link
Member

Thanks a lot 👍

Could you open an issue about this if link.is_wheel: block?

@finswimmer finswimmer merged commit 1aa4d5b into python-poetry:master Jan 1, 2022
@finswimmer finswimmer linked an issue Jan 1, 2022 that may be closed by this pull request
This locked is assigned but not used? #4961
Closed
2 tasks
@Anselmoo
Copy link
Contributor Author

Anselmoo commented Jan 1, 2022

Thanks a lot 👍

Could you open an issue about this if link.is_wheel: block?

I will do! Thx for Your support

@Anselmoo Anselmoo mentioned this pull request Jan 1, 2022
Closed
2 tasks
@Anselmoo Anselmoo deleted the refactors branch January 2, 2022 08:51
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

This locked is assigned but not used?
2 participants
@Anselmoo @finswimmer